Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Clean Output #939

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Clean Output #939

merged 4 commits into from
Nov 8, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Nov 7, 2021 •
edited
Loading

What does this PR do?

Fixes #925
Fixes #926

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 7, 2021 •
edited
Loading

Codecov Report

Merging #939 (3fcd45a) into master (4a242e6) will increase coverage by 9.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   78.57%   88.31%   +9.73%     
==========================================
  Files         242      242              
  Lines       13053    13030      -23     
==========================================
+ Hits        10256    11507    +1251     
+ Misses       2797     1523    -1274
Flag Coverage Δ
unittests 88.31% <100.00%> (+9.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/audio/speech_recognition/model.py 100.00% <ø> (ø)
flash/image/classification/model.py 75.00% <ø> (+4.54%) ⬆️
flash/image/detection/model.py 100.00% <ø> (+26.66%) ⬆️
flash/image/segmentation/model.py 91.89% <ø> (ø)
flash/pointcloud/detection/model.py 81.96% <ø> (ø)
flash/pointcloud/segmentation/model.py 75.86% <ø> (ø)
flash/tabular/classification/model.py 92.50% <ø> (ø)
flash/tabular/regression/model.py 51.35% <ø> (ø)
flash/template/classification/model.py 97.05% <ø> (ø)
flash/text/classification/model.py 92.59% <ø> (+24.07%) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a242e6...3fcd45a. Read the comment docs.

pietrolesci
pietrolesci approved these changes Nov 7, 2021
View reviewed changes
Copy link
Contributor

@pietrolesci pietrolesci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tchaton
tchaton approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ethanwharris ethanwharris merged commit 8de809e into master Nov 8, 2021
@ethanwharris ethanwharris deleted the feature/remove_output_enable branch November 8, 2021 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pietrolesci pietrolesci pietrolesci approved these changes

@tchaton tchaton tchaton approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
Data Pipeline V2 Refactor (Functional)
Projects
None yet
Milestone
No milestone
3 participants
@ethanwharris @tchaton @pietrolesci